Details

    • Type: Feature Request
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: OpenVZ-legacy
    • Component/s: Containers::Userspace
    • Security Level: Public
    • Environment:
      Operating System: Other
      Platform: Other

      Description

      vzctl is unable to handle symlink files for config file in certain case ( cross-device )

      I've made a patch which handle this.
      1. vzctl_write_conf_canonical.diff
        0.8 kB
        xavier martin
      2. vzctl-symlink.diff
        3 kB
        xavier martin

        Issue Links

          Activity

          Hide
          xavier.martin@enovance.com xavier martin added a comment -

          Attachment vzctl-symlink.diff has been added with description: apply to 3.0.23

          Show
          xavier.martin@enovance.com xavier martin added a comment - Attachment vzctl-symlink.diff has been added with description: apply to 3.0.23
          Hide
          kir Kir Kolyshkin added a comment -

          Looks good, but can we use canonicalize_file_name(3) for that?

          Show
          kir Kir Kolyshkin added a comment - Looks good, but can we use canonicalize_file_name(3) for that?
          Hide
          xavier.martin@enovance.com xavier martin added a comment -

          Attachment vzctl_write_conf_canonical.diff has been added with description: canonicalize_fine_name

          Show
          xavier.martin@enovance.com xavier martin added a comment - Attachment vzctl_write_conf_canonical.diff has been added with description: canonicalize_fine_name
          Hide
          xavier.martin@enovance.com xavier martin added a comment -

          indeed, it works as expected

          Show
          xavier.martin@enovance.com xavier martin added a comment - indeed, it works as expected
          Hide
          kir Kir Kolyshkin added a comment - - edited

          1. you need to free() the result of canonicalize_file_name()
          2. the proper way to #define _GNU_SOURCE is:

          #ifndef _GNU_SOURCE
          #define _GNU_SOURCE
          #endif

          Show
          kir Kir Kolyshkin added a comment - - edited 1. you need to free() the result of canonicalize_file_name() 2. the proper way to #define _GNU_SOURCE is: #ifndef _GNU_SOURCE #define _GNU_SOURCE #endif
          Hide
          kir Kir Kolyshkin added a comment - - edited
          Show
          kir Kir Kolyshkin added a comment - - edited Fixed in GIT: http://git.openvz.org/?p=vzctl;a=commit;h=35c8a3e3c963446e98b087ea629f32647512af25 Plus an improvement related to this bugreport: http://git.openvz.org/?p=vzctl;a=commit;h=51e5e8708c3a590dec70f38668894a3e06a70c0f Will be available in vzctl >= 3.0.24.
          Hide
          sergeyb Sergey Bronnikov added a comment -

          Bug was fixed more than one year ago and there were no complains from reporter after fix. We believe bug fix helped and mark bug as closed.

          Show
          sergeyb Sergey Bronnikov added a comment - Bug was fixed more than one year ago and there were no complains from reporter after fix. We believe bug fix helped and mark bug as closed.

            People

            • Assignee:
              igor Igor Sukhih
              Reporter:
              xavier.martin@enovance.com xavier martin
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: