Uploaded image for project: 'OpenVZ'
  1. OpenVZ
  2. OVZ-4545

if live migration migration fails /etc/vz/names/CTNAME is not removed on the destionation host

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: OpenVZ-legacy
    • Component/s: Containers::Userspace
    • Security Level: Public
    • Environment:
      Operating System: Other
      Platform: Other

      Description

      Then live migration fails the /etc/vz/conf/CTID.conf is removed on the destination host but /etc/vz/names/CTNAME is not

        Activity

        Hide
        lolitushka@gmail.com piavlo added a comment -

        bump

        Show
        lolitushka@gmail.com piavlo added a comment - bump
        Hide
        kir Kir Kolyshkin added a comment -

        Ughm. To solve this in a proper way we need to implement 'vzctl unset' first. The hack would be to use vzctl set $CTID --name '' --save which will lead to the same result plus clearing the name in config file which we don't mind

        Show
        kir Kir Kolyshkin added a comment - Ughm. To solve this in a proper way we need to implement 'vzctl unset' first. The hack would be to use vzctl set $CTID --name '' --save which will lead to the same result plus clearing the name in config file which we don't mind
        Hide
        kir Kir Kolyshkin added a comment -

        Can you please check if the attached patch helps? I tested it lightly and it looks like it's correct one, but it would be better if you give it a try.

        If you don't want to apply patch, simply modify the vzmigrate script to add the following line:

        $SSH "root@$host" "vzctl set $VEID --name '' --save > /dev/null"

        right after

        undo_conf () {

        Show
        kir Kir Kolyshkin added a comment - Can you please check if the attached patch helps? I tested it lightly and it looks like it's correct one, but it would be better if you give it a try. If you don't want to apply patch, simply modify the vzmigrate script to add the following line: $SSH "root@$host" "vzctl set $VEID --name '' --save > /dev/null" right after undo_conf () {
        Hide
        kir Kir Kolyshkin added a comment -

        Attachment 0001-vzmigrate-remove-CT-name-after-unsuccessful-migratio.patch has been added with description: fix

        Show
        kir Kir Kolyshkin added a comment - Attachment 0001-vzmigrate-remove-CT-name-after-unsuccessful-migratio.patch has been added with description: fix
        Hide
        lolitushka@gmail.com piavlo added a comment -

        (In reply to comment #3)
        > Created an attachment (id=1135) [details]
        > fix
        >
        > Can you please check if the attached patch helps? I tested it lightly and it
        > looks like it's correct one, but it would be better if you give it a try.

        Seems to be working for me too, thanks.

        >
        > If you don't want to apply patch, simply modify the vzmigrate script to add the
        > following line:
        >
        > $SSH "root@$host" "vzctl set $VEID --name '' --save > /dev/null"
        >
        > right after
        >
        > undo_conf () {

        Show
        lolitushka@gmail.com piavlo added a comment - (In reply to comment #3) > Created an attachment (id=1135) [details] > fix > > Can you please check if the attached patch helps? I tested it lightly and it > looks like it's correct one, but it would be better if you give it a try. Seems to be working for me too, thanks. > > If you don't want to apply patch, simply modify the vzmigrate script to add the > following line: > > $SSH "root@$host" "vzctl set $VEID --name '' --save > /dev/null" > > right after > > undo_conf () {
        Hide
        kir Kir Kolyshkin added a comment -
        Show
        kir Kir Kolyshkin added a comment - Fixed in GIT: http://git.openvz.org/?p=vzctl;a=commit;h=f4f33b736acd225f014582495d154887f4c3e8a2 will appear in vzctl >= 3.0.24
        Hide
        kir Kir Kolyshkin added a comment -

        (In reply to comment #2)
        > Ughm. To solve this in a proper way we need to implement 'vzctl unset' first.

        Filed OVZ-4579.

        Show
        kir Kir Kolyshkin added a comment - (In reply to comment #2) > Ughm. To solve this in a proper way we need to implement 'vzctl unset' first. Filed OVZ-4579 .
        Hide
        sergeyb Sergey Bronnikov added a comment -

        Bug was fixed more than one year ago and there were no complains from reporter after fix. We believe bug fix helped and mark bug as closed.

        Show
        sergeyb Sergey Bronnikov added a comment - Bug was fixed more than one year ago and there were no complains from reporter after fix. We believe bug fix helped and mark bug as closed.

          People

          • Assignee:
            kir Kir Kolyshkin
            Reporter:
            lolitushka@gmail.com piavlo
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: