Uploaded image for project: 'OpenVZ'
  1. OpenVZ
  2. OVZ-4019

vzmigrate destroys VE by default

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: OpenVZ-legacy
    • Component/s: Containers::Userspace
    • Security Level: Public
    • Environment:
      Operating System: Debian
      Platform: x86 (i386)

      Description

      In case of migrating from host 'A' to host 'B' and there is no rsync installed on host 'B', vzmigrate doesn't fail but deletes the source VE by default.

      Maybe this is because the

      remove_area=1

      line in vzmigrate script.

      There is no wiki and man about this default setting.

        Activity

        Hide
        ola@inguza.com Ola Lundqvist added a comment -

        We need a method to check that rsync exists on the remote side and then exit in that case before the remove command starts. Removing the local area is not documented in the manpage and should be documented.

        Show
        ola@inguza.com Ola Lundqvist added a comment - We need a method to check that rsync exists on the remote side and then exit in that case before the remove command starts. Removing the local area is not documented in the manpage and should be documented.
        Hide
        kir Kir Kolyshkin added a comment -

        This bug is caused by the fact that we lose exit code from rsync due to added crap^W stuff. We have removed that stuff, so rsync fail is handled properly.

        Fixed by the following commit:
        http://git.openvz.org/?p=vzctl;a=commit;h=b430dfded9698b9132d5bfdb8d41b165f4f322f1

        "remove area" is documented in vzmigrate.8 man page:

        -r, --remove-area yes|no
        Whether to remove a container area on source HN for the success-
        fully migrated container.

        But its default is not documented. I fixed it by this commit:
        http://git.openvz.org/?p=vzctl;a=commit;h=4a870373d9d43a318baff2c9d7c580a2744f1c09

        Both fixes will appear in >= vzctl-3.0.24

        Show
        kir Kir Kolyshkin added a comment - This bug is caused by the fact that we lose exit code from rsync due to added crap^W stuff. We have removed that stuff, so rsync fail is handled properly. Fixed by the following commit: http://git.openvz.org/?p=vzctl;a=commit;h=b430dfded9698b9132d5bfdb8d41b165f4f322f1 "remove area" is documented in vzmigrate.8 man page: -r, --remove-area yes|no Whether to remove a container area on source HN for the success- fully migrated container. But its default is not documented. I fixed it by this commit: http://git.openvz.org/?p=vzctl;a=commit;h=4a870373d9d43a318baff2c9d7c580a2744f1c09 Both fixes will appear in >= vzctl-3.0.24
        Hide
        sergeyb Sergey Bronnikov added a comment -

        Bug was fixed more than one year ago and there were no complains from reporter after fix. We believe bug fix helped and mark bug as closed.

        Show
        sergeyb Sergey Bronnikov added a comment - Bug was fixed more than one year ago and there were no complains from reporter after fix. We believe bug fix helped and mark bug as closed.

          People

          • Assignee:
            amirkin@openvz.org Andrey Mirkin
            Reporter:
            openvzbugzilla@tuxworx.hu mogorva
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: